Fix Test-Data Validation #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates test-data validation for literal directives by adding new SQL test cases and updating the DAO interface method signature accordingly.
- Added new SQL test cases for boolean and null literal handling.
- Updated the DAO method signature to include new parameters for literal test values.
- Modified the SQL visitor to improve case-insensitive matching of literal values.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/test/testData/src/main/resources/META-INF/doma/example/dao/inspection/TestDataCheckDao/literalDirective.sql | Added test cases for literalTrue, literalFalse, and literalNull |
| src/test/testData/src/main/java/doma/example/dao/inspection/TestDataCheckDao.java | Updated method signature to include additional literal parameters |
| src/main/kotlin/org/domaframework/doma/intellij/inspection/sql/visitor/SqlTestDataAfterBlockCommentVisitor.kt | Improved literal matching by normalizing case |
...rc/main/resources/META-INF/doma/example/dao/inspection/TestDataCheckDao/literalDirective.sql
Show resolved
Hide resolved
src/test/testData/src/main/java/doma/example/dao/inspection/TestDataCheckDao.java
Outdated
Show resolved
Hide resolved
…update SQL binding logic
xterao
force-pushed
the
fix/test-data-validation
branch
from
ba6404b to
f6d8682
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalize the text that follows a block comment to lowercase, ensuring that literal values are detected as test data regardless of their original letter case.